WillAyd commented on code in PR #45909:
URL: https://github.com/apache/arrow/pull/45909#discussion_r2012041868
##########
cpp/src/arrow/meson.build:
##########
@@ -459,24 +463,27 @@ if needs_ipc
}
endif
-if needs_tests
- foreach key, val : arrow_tests
- exc = executable(
- key,
- sources: val['sources'],
- dependencies: [arrow_test_dep, val.get('dependencies', [])],
- )
- test(key, exc)
- endforeach
-endif
+foreach key, val : arrow_tests
+ exc = executable(
+ key,
+ sources: val['sources'],
+ dependencies: [arrow_test_dep, val.get('dependencies', [])],
+ )
+ test(key, exc)
+endforeach
if needs_benchmarks
benchmark_dep = dependency(
'benchmark',
default_options: {'tests': 'disabled'},
)
+
+ arrow_benchmark_dep = declare_dependency(
+ link_with: [arrow_test_lib],
+ dependencies: [arrow_dep, gtest_main_dep, benchmark_dep],
Review Comment:
Yes we can. The only possible downside to doing so is that we would still
need the gtest dependency, just without the main executable attached to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
