etseidl commented on code in PR #7321: URL: https://github.com/apache/arrow-rs/pull/7321#discussion_r2012845984
########## parquet/src/arrow/async_writer/mod.rs: ########## @@ -15,10 +15,12 @@ // specific language governing permissions and limitations // under the License. -//! Contains async writer which writes arrow data into parquet data. +//! `async` API for writing [`RecordBatch`]es to Parquet files //! -//! Provides `async` API for writing [`RecordBatch`]es as parquet files. The API is -//! similar to the [`sync` API](crate::arrow::arrow_writer::ArrowWriter), so please +//! See the [crate-level documentation](crate) for more details. +//! +//! The `async` API for writing [`RecordBatch`]es is Review Comment: ```suggestion //! The `async` API for writing [`RecordBatch`]es is ``` ########## parquet/src/lib.rs: ########## @@ -52,28 +52,47 @@ //! The [`schema`] module provides APIs to work with Parquet schemas. The //! [`file::metadata`] module provides APIs to work with Parquet metadata. //! -//! ## Read/Write Arrow +//! ## Reading and Writing Arrow (`arrow` feature) //! -//! The [`arrow`] module allows reading and writing Parquet data to/from Arrow `RecordBatch`. -//! This makes for a simple and performant interface to parquet data, whilst allowing workloads -//! to leverage the wide range of data transforms provided by the [arrow] crate, and by the -//! ecosystem of libraries and services using [Arrow] as an interop format. +//! The [`arrow`] module supports reading and writing Parquet data to/from +//! Arrow `RecordBatch`es. Using Arrow is simple and performant, and allows workloads +//! to leverage the wide range of data transforms provided by the [arrow] crate, the +//! ecosystem of [Arrow] compatible systems. Review Comment: Not sure why you dropped "and by" here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
