pitrou commented on code in PR #45881:
URL: https://github.com/apache/arrow/pull/45881#discussion_r2016063830
##########
python/pyarrow/tests/test_fs.py:
##########
@@ -1251,6 +1251,10 @@ def test_s3_options(pickle_module):
assert isinstance(fs, S3FileSystem)
assert pickle_module.loads(pickle_module.dumps(fs)) == fs
+ fs = S3FileSystem(endpoint_override='localhost:8999',
tls_ca_file_path="ca.pem")
+ assert isinstance(fs, S3FileSystem)
+ assert pickle_module.loads(pickle_module.dumps(fs)) == fs
Review Comment:
We should also test that this produces a different filesystem than without
the option, for example:
```suggestion
fs = S3FileSystem(tls_ca_file_path="ca.pem")
assert isinstance(fs, S3FileSystem)
assert pickle_module.loads(pickle_module.dumps(fs)) == fs
assert fs != S3FileSystem(tls_ca_file_path="other_ca.pem")
assert fs != S3FileSystem()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
