pitrou commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r2016083112
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -428,13 +429,19 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
}
case ArrowTypeId::EXTENSION: {
auto ext_type =
std::static_pointer_cast<::arrow::ExtensionType>(field->type());
- // Built-in JSON extension is handled differently.
+ // Built-in JSON extension and GeoArrow are handled differently.
if (ext_type->extension_name() == std::string("arrow.json")) {
// Set physical and logical types and instantiate primitive node.
type = ParquetType::BYTE_ARRAY;
logical_type = LogicalType::JSON();
break;
+ } else if (ext_type->extension_name() == std::string("geoarrow.wkb")) {
Review Comment:
Nit: would it work with a string view instead?
```suggestion
} else if (ext_type->extension_name() ==
std::string_view("geoarrow.wkb")) {
```
(if so, could also change other occurrences here, or not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
