pitrou commented on code in PR #45754:
URL: https://github.com/apache/arrow/pull/45754#discussion_r2016741584
##########
dev/archery/archery/bot.py:
##########
@@ -339,54 +338,65 @@ def _clone_arrow_and_crossbow(dest, crossbow_repo,
arrow_repo_url, pr_number):
"https://github.com/apache/arrow.git".
pr_number : int
Target PR number.
+
"""
- arrow_path = dest / 'arrow'
- queue_path = dest / 'crossbow'
+ arrow_path = dest / "arrow"
+ queue_path = dest / "crossbow"
# we use unique branch name instead of fork's branch name to avoid
# branch name conflict such as 'main' (GH-39996)
- local_branch = f'archery/pr-{pr_number}'
+ local_branch = f"archery/pr-{pr_number}"
# 1. clone arrow and checkout the PR's branch
- pr_ref = f'pull/{pr_number}/head:{local_branch}'
- git.clone('--no-checkout', arrow_repo_url, str(arrow_path))
+ pr_ref = f"pull/{pr_number}/head:{local_branch}"
+ git.clone("--no-checkout", arrow_repo_url, str(arrow_path))
# fetch the PR's branch into the clone
- git.fetch('origin', pr_ref, git_dir=arrow_path)
+ git.fetch("origin", pr_ref, git_dir=arrow_path)
# checkout the PR's branch into the clone
git.checkout(local_branch, git_dir=arrow_path)
# 2. clone crossbow repository
- crossbow_url = 'https://github.com/{}'.format(crossbow_repo)
+ crossbow_url = f"https://github.com/{crossbow_repo}"
git.clone(crossbow_url, str(queue_path))
# 3. initialize crossbow objects
- github_token = os.environ['CROSSBOW_GITHUB_TOKEN']
+ github_token = os.environ["CROSSBOW_GITHUB_TOKEN"]
arrow = Repo(arrow_path)
queue = Queue(queue_path, github_token=github_token, require_https=True)
return (arrow, queue)
@crossbow.command()
[email protected]('tasks', nargs=-1, required=False)
[email protected]('--group', '-g', 'groups', multiple=True,
- help='Submit task groups as defined in tests.yml')
[email protected]('--param', '-p', 'params', multiple=True,
- help='Additional task parameters for rendering the CI templates')
[email protected]('--arrow-version', '-v', default=None,
- help='Set target version explicitly.')
[email protected]('--wait', default=60,
- help='Wait the specified seconds before generating a report.')
[email protected]('--prefix', default='actions',
- help='Prefix for job IDs.')
[email protected]("tasks", nargs=-1, required=False)
[email protected](
+ "--group",
+ "-g",
+ "groups",
+ multiple=True,
+ help="Submit task groups as defined in tests.yml",
+)
Review Comment:
Here as well, would like to avoid this much vertical spacing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]