paleolimbot commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r2017496308
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1104,9 +1107,18 @@ int64_t ColumnWriterImpl::Close() {
if (rows_written_ > 0 && chunk_statistics.is_set()) {
metadata_->SetStatistics(chunk_statistics);
}
+
if (rows_written_ > 0 && chunk_size_statistics.is_set()) {
metadata_->SetSizeStatistics(chunk_size_statistics);
}
+
+ if (descr_->logical_type() != nullptr &&
descr_->logical_type()->is_geometry()) {
Review Comment:
Geography columns can have statistics but generating them is a battle for a
different day 🙂 (it's much more complicated than a simple min/max by dimension
and probably requires figuring out how to wire up an existing implementation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
