kszucs commented on code in PR #45360: URL: https://github.com/apache/arrow/pull/45360#discussion_r2017707076
########## cpp/src/parquet/schema.cc: ########## @@ -28,6 +28,7 @@ #include "parquet/exception.h" #include "parquet/schema_internal.h" #include "parquet/thrift_internal.h" +#include "parquet/windows_fixup.h" // for OPTIONAL Review Comment: I had to add the windows fixup here to overcome ``` In file included from D:/a/arrow/arrow/build/cpp/src/parquet/CMakeFiles/parquet_shared.dir/Unity/unity_3_cxx.cxx:16: D:/a/arrow/arrow/cpp/src/parquet/schema.cc: In function 'void parquet::schema::PrintRepLevel(parquet::Repetition::type, std::ostream&)': D:/a/arrow/arrow/cpp/src/parquet/schema.cc:630:30: error: expected unqualified-id before ':' token 630 | case Repetition::OPTIONAL: ``` https://github.com/apache/arrow/actions/runs/14115826826/job/39545693922?pr=45360#step:7:838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org