NinaPeng commented on a change in pull request #9060:
URL: https://github.com/apache/arrow/pull/9060#discussion_r604630536
##########
File path: cpp/src/gandiva/field_descriptor.h
##########
@@ -58,12 +63,15 @@ class FieldDescriptor {
bool HasDataBufferPtrIdx() const { return data_buffer_ptr_idx_ !=
kInvalidIdx; }
+ bool HasChildOffsetsIdx() const { return child_offsets_idx_ != kInvalidIdx; }
+
private:
FieldPtr field_;
int data_idx_;
int validity_idx_;
int offsets_idx_;
int data_buffer_ptr_idx_;
+ int child_offsets_idx_;
Review comment:
Got it. It's better to add child validity index for more list type
computation. I'll fix it as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
