murfffi commented on PR #2637:
URL: https://github.com/apache/arrow-adbc/pull/2637#issuecomment-2763233240

   > Sorry for the delay on the response here, this looks good to me in 
general, but can we add a test which contains more than one type in the union? 
With results from both types and ensure that we get the correct values for each 
index?
   > 
   > Also, can we please add a test for DenseUnion in addition to the test with 
SparseUnion?
   
   Added. Forgot to ask if squashed commits are preferred.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to