jonkeane commented on code in PR #45951:
URL: https://github.com/apache/arrow/pull/45951#discussion_r2020945049
##########
r/tests/testthat/test-altrep.R:
##########
@@ -170,7 +170,7 @@ test_that("element access methods for int32 ALTREP with
nulls", {
expect_identical(test_arrow_altrep_copy_by_region(altrep, 123), original)
expect_false(test_arrow_altrep_is_materialized(altrep))
- # because there are no nulls, DATAPTR() does not materialize
+ # because there are nulls, DATAPTR() does materialize
Review Comment:
This comment change and the one below are not _behavior_ changes with this
PR, but I think the comments were simply wrong (either old or copy pasted).
I've tried to correct them to be accurate descriptions of what's going on (but
see "does not materialize" and then two lines later
`expect_true(test_arrow_altrep_is_materialized(altrep))` is at odds with each
other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
