jbonofre commented on code in PR #693:
URL: https://github.com/apache/arrow-java/pull/693#discussion_r2021087618
##########
vector/src/main/java/org/apache/arrow/vector/Decimal256Vector.java:
##########
@@ -566,9 +566,7 @@ private class TransferImpl implements TransferPair {
Decimal256Vector to;
public TransferImpl(String ref, BufferAllocator allocator) {
- to =
- new Decimal256Vector(
- ref, allocator, Decimal256Vector.this.precision,
Decimal256Vector.this.scale);
+ to = new Decimal256Vector(ref,
Decimal256Vector.this.field.getFieldType(), allocator);
Review Comment:
Shouldn't we test with `field`/`getFiedlType()` is not null and fallback to
the vector precision if null ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
