projjal commented on a change in pull request #9785:
URL: https://github.com/apache/arrow/pull/9785#discussion_r604884393
##########
File path: cpp/src/gandiva/tests/in_expr_test.cc
##########
@@ -34,6 +35,19 @@ class TestIn : public ::testing::Test {
protected:
arrow::MemoryPool* pool_;
};
+std::vector<Decimal128> MakeDecimalVector(std::vector<std::string> values) {
+ std::vector<arrow::Decimal128> ret;
+ for (auto str : values) {
+ Decimal128 str_value;
+ int32_t str_precision;
+ int32_t str_scale;
Review comment:
decimal_value, decimal_precision, decimal_scale?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
