zeroshade commented on code in PR #336:
URL: https://github.com/apache/arrow-go/pull/336#discussion_r2021255204
##########
parquet/metadata/column_chunk.go:
##########
@@ -349,12 +357,12 @@ type EncodingStats struct {
// Finish finalizes the metadata with the given offsets,
// flushes any compression that needs to be done, and performs
// any encryption if an encryptor is provided.
-func (c *ColumnChunkMetaDataBuilder) Finish(info ChunkMetaInfo, hasDict,
dictFallback bool, encStats EncodingStats, metaEncryptor encryption.Encryptor)
error {
Review Comment:
I was trying to avoid breaking changes. But I guess i can remove it entirely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
