HugoCasa commented on issue #315:
URL: 
https://github.com/apache/arrow-rs-object-store/issues/315#issuecomment-2769104171

   Here's a reproducer with an invalid character in the bucket name:
   
   ```rust
   use object_store::{ObjectStore, aws::AmazonS3Builder, path::Path};
   
   #[tokio::main]
   async fn main() {
       let store_builder = AmazonS3Builder::new()
           .with_bucket_name("\n")
           .with_region("asd")
           .with_skip_signature(true);
   
       let store = store_builder.build().unwrap();
   
       store.get(&Path::from("asd")).await.unwrap();
   }
   ```
   
   In our case, the config is defined by the end user which can therefore 
contain invalid characters. We could validate it ourselves but the logic is 
already in the library, but panics instead of throwing the error. Maybe an 
alternative solution would be to validate the bucket name/region/etc... when 
building the store.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to