pitrou commented on a change in pull request #9863:
URL: https://github.com/apache/arrow/pull/9863#discussion_r605010147
##########
File path: cpp/src/parquet/thrift_internal.h
##########
@@ -256,6 +256,8 @@ static inline format::Type::type ToThrift(Type::type type) {
static inline format::ConvertedType::type ToThrift(ConvertedType::type type) {
// item 0 is NONE
DCHECK_NE(type, ConvertedType::NONE);
+ // it is forbidden to emit "NA" (PARQUET-1990)
+ DCHECK_NE(type, ConvertedType::NA);
Review comment:
I don't think it would change anything. Or we would have to do a
full-blown check for valid values, which is a bit out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
