mbutrovich commented on PR #7358: URL: https://github.com/apache/arrow-rs/pull/7358#issuecomment-2770762078
So, almost the entire codebase uses compile time constant args that are powers of two to `ceil` so those will generate equivalent shifts. The exception is `arrow_row::variable::padded_length`. That gets inlined in `encoded_len`, which in turn gets inlined a bunch of times in `row_lengths`. So let's dive into that! [Online diff.](https://www.diffchecker.com/32e9GSeV/) Darn. Aside from label names, they're exactly the same. I really thought I'd find a difference. Long way of saying, there should not be measurable performance differences on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
