adamreeve commented on code in PR #7369:
URL: https://github.com/apache/arrow-rs/pull/7369#discussion_r2023774088
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -192,26 +188,7 @@ impl ArrowReaderMetadata {
input: &mut T,
options: ArrowReaderOptions,
) -> Result<Self> {
- // TODO: this is all rather awkward. It would be nice if
AsyncFileReader::get_metadata
- // took an argument to fetch the page indexes.
- let mut metadata = input.get_metadata(Some(&options)).await?;
-
- if options.page_index
- && metadata.column_index().is_none()
- && metadata.offset_index().is_none()
- {
- let m = Arc::try_unwrap(metadata).unwrap_or_else(|e|
e.as_ref().clone());
- let mut reader =
ParquetMetaDataReader::new_with_metadata(m).with_page_indexes(true);
-
- #[cfg(feature = "encryption")]
- {
- reader =
-
reader.with_decryption_properties(options.file_decryption_properties.as_ref());
- }
-
- reader.load_page_index(input).await?;
- metadata = Arc::new(reader.finish()?)
- }
+ let metadata = input.get_metadata(Some(&options)).await?;
Review Comment:
Should the note in the doc comment above be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
