kou commented on code in PR #45981:
URL: https://github.com/apache/arrow/pull/45981#discussion_r2024257546
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -958,6 +958,9 @@ set(EP_COMMON_CMAKE_ARGS
-DCMAKE_INSTALL_LIBDIR=lib
-DCMAKE_OSX_SYSROOT=${CMAKE_OSX_SYSROOT}
-DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE}
+ # We set CMAKE_POLICY_VERSION_MINIMUM temporarily due to failures with
CMake 4
+ # We should remove it once we have updated the dependencies:
+ # https://github.com/apache/arrow/issues/45985
-DCMAKE_POLICY_VERSION_MINIMUM=3.5)
Review Comment:
Can we disable this in `build_snappy`?
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index f4de617ced..21676ea5f1 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1387,6 +1387,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF
-DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
+ # We can remove this once we remove -DCMAKE_POLICY_VERSION_MINIMUM=3.5
+ # from EP_COMMON_CMAKE_ARGS.
+ list(REMOVE_ITEM SNAPPY_CMAKE_ARGS -DCMAKE_POLICY_VERSION_MINIMUM=3.5)
# Snappy unconditionally enables -Werror when building with clang this
can lead
# to build failures by way of new compiler warnings. This adds a flag to
disable
# -Werror to the very end of the invocation to override the snappy
internal setting.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
