lidavidm commented on a change in pull request #9607:
URL: https://github.com/apache/arrow/pull/9607#discussion_r605008692
##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -150,18 +199,43 @@ class ARROW_DS_EXPORT Scanner {
Scanner(std::shared_ptr<Fragment> fragment, std::shared_ptr<ScanOptions>
scan_options)
: fragment_(std::move(fragment)), scan_options_(std::move(scan_options))
{}
- /// \brief The Scan operator returns a stream of ScanTask. The caller is
+ /// \brief The Scan operator returns a stream of ScanTask futures. The
caller is
/// responsible to dispatch/schedule said tasks. Tasks should be safe to run
/// in a concurrent fashion and outlive the iterator.
+ PositionedRecordBatchGenerator ScanUnorderedAsync();
+
+ /// \brief The scan tasks returned in this version will be
Review comment:
```suggestion
/// \brief The record batches returned in this version will be
```
##########
File path: cpp/src/arrow/util/async_generator.h
##########
@@ -998,6 +1058,19 @@ class MergedGenerator {
std::shared_ptr<State> state_;
};
+template <typename T>
Review comment:
nit: document that this is async-reentrant
##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -150,18 +199,43 @@ class ARROW_DS_EXPORT Scanner {
Scanner(std::shared_ptr<Fragment> fragment, std::shared_ptr<ScanOptions>
scan_options)
: fragment_(std::move(fragment)), scan_options_(std::move(scan_options))
{}
- /// \brief The Scan operator returns a stream of ScanTask. The caller is
+ /// \brief The Scan operator returns a stream of ScanTask futures. The
caller is
Review comment:
```suggestion
/// \brief The Scan operator returns a stream of RecordBatch futures. The
caller is
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
