alamb commented on code in PR #7372:
URL: https://github.com/apache/arrow-rs/pull/7372#discussion_r2025280219
##########
parquet/src/file/metadata/reader.rs:
##########
@@ -710,7 +710,11 @@ impl ParquetMetaDataReader {
));
}
- Ok((self.decode_footer_metadata(&meta, &footer)?, None))
+ Ok((
+ // need to slice off the footer or decryption fails
+ self.decode_footer_metadata(&meta.slice(0..length), &footer)?,
+ None,
Review Comment:
I verified that without this change the new test fails like this:
```
---- file::metadata::reader::async_tests::test_suffix_with_encryption stdout
----
thread 'file::metadata::reader::async_tests::test_suffix_with_encryption'
panicked at parquet/src/file/metadata/reader.rs:1458:14:
called `Result::unwrap()` on an `Err` value: General("Provided footer key
and AAD were unable to decrypt parquet footer")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
