comphead commented on PR #7179: URL: https://github.com/apache/arrow-rs/pull/7179#issuecomment-2774001657
> My benchmark results seem to show that this PR significantly slows down decimal parsing, anywhere fro 3 to 17% slower than main. I will rerun to see if I can reproduce these numbers > > ```shell > cargo bench --bench parse_decimal > ``` > > Here are the results I got: > > ```shell > group fix_parse_decimal_for_rounding_scale_zero main > ----- ----------------------------------------- ---- > -.123 1.10 22.8±0.01ns ? ?/sec 1.00 20.7±0.03ns ? ?/sec > -00.1 1.06 33.5±0.02ns ? ?/sec 1.00 31.6±0.08ns ? ?/sec > -12. 1.03 38.6±0.04ns ? ?/sec 1.00 37.3±0.14ns ? ?/sec > -123 1.07 39.2±0.07ns ? ?/sec 1.00 36.8±0.16ns ? ?/sec > -123. 1.05 42.1±0.09ns ? ?/sec 1.00 40.3±0.24ns ? ?/sec > -123.1 1.07 41.1±0.04ns ? ?/sec 1.00 38.4±0.27ns ? ?/sec > -123.123 1.12 32.5±0.03ns ? ?/sec 1.00 29.0±0.03ns ? ?/sec > -123.1234 1.14 34.3±0.09ns ? ?/sec 1.00 30.0±0.02ns ? ?/sec > -12345678912345678.1234 1.21 88.8±0.13ns ? ?/sec 1.00 73.4±0.06ns ? ?/sec > -99999999999999999.999 1.19 86.8±0.08ns ? ?/sec 1.00 72.8±0.08ns ? ?/sec > .123 1.09 21.8±0.03ns ? ?/sec 1.00 19.9±0.02ns ? ?/sec > 0.0000123 1.14 26.3±0.08ns ? ?/sec 1.00 23.1±0.03ns ? ?/sec > 00.1 1.08 33.1±0.16ns ? ?/sec 1.00 30.7±0.06ns ? ?/sec > 12. 1.07 38.4±0.06ns ? ?/sec 1.00 36.0±0.13ns ? ?/sec > 123 1.10 39.1±0.16ns ? ?/sec 1.00 35.7±0.09ns ? ?/sec > 123. 1.10 43.3±5.95ns ? ?/sec 1.00 39.4±0.14ns ? ?/sec > 123.1 1.11 41.2±0.13ns ? ?/sec 1.00 37.2±0.09ns ? ?/sec > 123.123 1.14 32.3±0.03ns ? ?/sec 1.00 28.2±0.09ns ? ?/sec > 123.1234 1.17 34.2±0.04ns ? ?/sec 1.00 29.3±0.04ns ? ?/sec > 12345678912345678.1234 1.24 90.0±0.09ns ? ?/sec 1.00 72.8±0.13ns ? ?/sec > 99999999999999999.999 1.22 88.1±0.11ns ? ?/sec 1.00 72.0±0.07ns ? ?/sec > ``` Thanks @alamb for pointing it out. Trying to profile it to get some hot spots -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
