kou commented on PR #46015: URL: https://github.com/apache/arrow/pull/46015#issuecomment-2774552214
We can use `DCHECK*()` macros in `*_internal.h` because they are not public headers but this PR changes them to `ARROW_DCHECK*()` macros. If we prefer `DCHECK*()` in `*_internal.h`, we can use `logging_internal.h` instead of using `ARROW_DCHECK*()`. If you have any opinion for this, please share it. I don't have a strong opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
