kylebarron commented on code in PR #322:
URL:
https://github.com/apache/arrow-rs-object-store/pull/322#discussion_r2027967858
##########
src/gcp/client.rs:
##########
@@ -640,9 +632,11 @@ impl GetClient for GoogleCloudStorageClient {
request = request.query(&[("generation", version)]);
}
- if !credential.bearer.is_empty() {
- request = request.bearer_auth(&credential.bearer);
- }
+ request = request.with_bearer_auth(credential.as_deref());
+
+ // if !credential.bearer.is_empty() {
+ // request = request.bearer_auth(&credential.bearer);
+ // }
Review Comment:
To ensure this PR isn't a breaking change, [`640f7f2`
(#322)](https://github.com/apache/arrow-rs-object-store/pull/322/commits/640f7f21e82ce4cbc9402c0f9e7aa3884fff3dc5)
implements this change, so we now skip signing when bearer is `""`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
