pitrou commented on code in PR #45789:
URL: https://github.com/apache/arrow/pull/45789#discussion_r2003099005
##########
cpp/src/arrow/acero/groupby_aggregate_node.cc:
##########
@@ -312,7 +312,7 @@ Result<ExecBatch> GroupByNode::Finalize() {
segment_key_field_ids_.size());
// Segment keys come first
- PlaceFields(out_data, 0, segmenter_values_);
+ PlaceFields(out_data, 0, state->segmenter_values);
Review Comment:
Yes, that sounds reasonable. If we wanted to have multi-threaded segmented
group-by, I suppose it would need a preparatory step to rechunk the input along
segment boundaries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
