kevingurney commented on code in PR #45973: URL: https://github.com/apache/arrow/pull/45973#discussion_r2029301782
########## matlab/doc/matlab_interface_for_apache_arrow_design.md: ########## @@ -131,33 +119,43 @@ Alternatively, they could directly convert from an existing MATLAB `table` to an >> Density = [10.2; 20.5; 11.2; 13.7; 17.8]; ->> T = table(Weight, Radius, Density); % Create a MATLAB table +% Create a MATLAB `table` +>> T = table(Weight, Radius, Density); ->> AT = arrow.matlab2arrow(T); % Create an arrow.Table +% Create an `arrow.tabular.Table` from the MATLAB `table` +>> AT = arrow.table(T); ``` -To serialize the `arrow.Table`, `AT`, to a file (e.g. Feather) on disk, the user could then instantiate an `arrow.FeatherTableWriter`. + +To serialize the `arrow.Table`, `AT`, to a file (e.g. Feather) on disk, the user could then instantiate an `arrow.internal.io.feather.Writer`. ###### Example Code: ``` matlab ->> featherTableWriter = arrow.FeatherTableWriter(); - ->> featherTableWriter.write(AT, "data.feather"); +% Make an `arrow.tabular.RecordBatch` from the `arrow.tabular.Table` created in the previous step +>> recordBatch = arrow.recordBatch(AT); +>> filename = "data.arrow"; +% Write the `arrow.tabular.RecordBatch` using Feather locally to `data.arrow` +>> writer = arrow.internal.io.feather.Writer(filename); +>> writer.write(recordBatch); ``` -The Feather file could then be read and operated on by an external process like Rust or Go. To read it back into MATLAB after modification by another process, the user could instantiate an `arrow.FeatherTableReader`. +The Feather file could then be read and operated on by an external process like Rust or Go. To read it back into MATLAB after modification by another process, the user could instantiate an `arrow.internal.io.feather.Reader`. Review Comment: ```suggestion The Feather V1 file could then be read and operated on by an external process like Rust or Go. To read it back into MATLAB, the user could instantiate an `arrow.internal.io.feather.Reader`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
