corwinjoy opened a new pull request, #7342:
URL: https://github.com/apache/arrow-rs/pull/7342
# Rationale for this change
In using encryption with datafusion, I found the default implementation for
`get_metadata_with_options` to be more of a hindrance than a help. What
happened, is that when working with encrypted parquet, my calls would
mysteriously fail and I could not understand why. It took me longer than I like
to admit to discover that the default implementation for
`get_metadata_with_options` would quietly drop decryption information, and that
was the source of my troubles. I propose that this default implementation
should be removed so that developers get a clear compiler message that they
should be explicit about what they want. If this is too much of a breaking API
change, then a second best solution would be to provide a runtime error. Either
way, I feel that the default implementation is simply too likely to cause
unexpected and surprising errors.
# What changes are included in this PR?
Remove the default implementation for get_metadata_with_options` for the `
AsyncFileReader: Send` trait.
# Are there any user-facing changes?
Users will need to be explicit about what they want to do for
`get_metadata_with_options ` for the ` AsyncFileReader: Send` trait. Having no
default implementation here is in line with other methods here. I feel that
asking users to be explicit is a good change here to prevent potential errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
