pitrou commented on code in PR #44279: URL: https://github.com/apache/arrow/pull/44279#discussion_r2015869906
########## docs/source/cpp/flight.rst: ########## @@ -239,7 +239,16 @@ Memory management ----------------- Flight tries to reuse allocations made by gRPC to avoid redundant -data copies. However, this means that those allocations may not +data copies. Experience shows that Arrow data in those allocations are not +found at aligned addresses. Some Flight client use cases may require `data alignment`_, Review Comment: No, I don't think this suggestion is correct @kou. What we're doing here is ensuring that is naturally aligned, e.g. int32 aligned to 4 bytes, not 64-byte aligned as recommended in the columnar spec. I would recommend something like this: ``` Flight tries to reuse allocations made by gRPC to avoid redundant data copies. However, experience shows that such data is frequently misaligned. Some use cases might require data to be "naturally" aligned (for example, for the data buffer of a Int32 array to be aligned on a 4-byte boundary), which can be enforced ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
