paleolimbot commented on code in PR #45866:
URL: https://github.com/apache/arrow/pull/45866#discussion_r2023316295


##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -1053,6 +1060,29 @@ Result<bool> ApplyOriginalMetadata(const Field& 
origin_field, SchemaField* infer
       // inferred_type is arrow::extension::json(arrow::utf8())
       auto origin_storage_field = 
origin_field.WithType(ex_type.storage_type());
 
+      // Apply metadata recursively to storage type
+      RETURN_NOT_OK(ApplyOriginalStorageMetadata(*origin_storage_field, 
inferred));
+      inferred->field = inferred->field->WithType(origin_type);
+    } else if (inferred_type->id() == ::arrow::Type::FIXED_SIZE_BINARY &&

Review Comment:
   I spent quite a bit of time rewriting the logic here...I *think* it's better 
than it was?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to