chilin0525 commented on code in PR #45629:
URL: https://github.com/apache/arrow/pull/45629#discussion_r2030019808
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -1357,9 +1351,9 @@ def validate(self):
Task(task_name, **task)
except Exception as e:
raise CrossbowError(
- 'Unable to construct a task object from the '
- 'definition of task `{}`. The original error message '
- 'is: `{}`'.format(task_name, str(e))
+ f"Unable to construct a task object from the "
Review Comment:
Resolved in
[2c7c552](https://github.com/apache/arrow/pull/45629/commits/2c7c552cf2119490867016bdce97578af1f1481b).
##########
dev/archery/archery/docker/cli.py:
##########
@@ -122,8 +122,8 @@ def docker_pull(obj, image, *, pull_leaf,
ignore_pull_failures):
ignore_pull_failures=ignore_pull_failures)
except UndefinedImage as e:
raise click.ClickException(
- "There is no service/image defined in docker-compose.yml with "
- "name: {}".format(str(e))
+ f"There is no service/image defined in docker-compose.yml with "
Review Comment:
Resolved in
[2c7c552](https://github.com/apache/arrow/pull/45629/commits/2c7c552cf2119490867016bdce97578af1f1481b).
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -1393,8 +1387,8 @@ def validate(self):
)
)
if not files:
- raise CrossbowError('No files have been rendered for task `{}`'
- .format(task_name))
+ raise CrossbowError(f"No files have been rendered for task "
Review Comment:
Resolved in
[2c7c552](https://github.com/apache/arrow/pull/45629/commits/2c7c552cf2119490867016bdce97578af1f1481b).
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -329,9 +329,9 @@ def remote(self):
return self.repo.remotes[self.branch.upstream.remote_name]
except (AttributeError, KeyError):
raise CrossbowError(
- 'Cannot determine git remote for the Arrow repository to '
- 'clone or push to, try to push the `{}` branch first to have '
- 'a remote tracking counterpart.'.format(self.branch.name)
+ f"Cannot determine git remote for the Arrow repository to "
Review Comment:
Resolved in
[2c7c552](https://github.com/apache/arrow/pull/45629/commits/2c7c552cf2119490867016bdce97578af1f1481b).
##########
dev/archery/archery/bot.py:
##########
@@ -291,11 +291,9 @@ def handle_issue_comment(self, command, payload):
comment=comment)
except Exception as e:
logger.exception(e)
- url = "{server}/{repo}/actions/runs/{run_id}".format(
- server=os.environ["GITHUB_SERVER_URL"],
- repo=os.environ["GITHUB_REPOSITORY"],
- run_id=os.environ["GITHUB_RUN_ID"],
- )
+ url = (f"{os.environ['GITHUB_SERVER_URL']}/"
Review Comment:
Sure, resolved in
[97070b2](https://github.com/apache/arrow/pull/45629/commits/97070b285f695bd65fe955fe866338505f7962cc)
##########
dev/archery/archery/crossbow/core.py:
##########
@@ -299,9 +299,9 @@ def push(self, refs=None, github_token=None):
try:
self.origin.push(refs + self._updated_refs, callbacks=callbacks)
except pygit2.GitError:
- raise RuntimeError('Failed to push updated references, '
- 'potentially because of credential issues: {}'
- .format(self._updated_refs))
+ raise RuntimeError(f"Failed to push updated references, "
Review Comment:
Resolved in
[2c7c552](https://github.com/apache/arrow/pull/45629/commits/2c7c552cf2119490867016bdce97578af1f1481b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
