raulcd commented on issue #45991: URL: https://github.com/apache/arrow/issues/45991#issuecomment-2785732756
The latest version for nlohman_json is from late 2023: - https://github.com/nlohmann/json/releases/tag/v3.11.3 There seems to be a discussion to do a new v3.12 release soon, see: - https://github.com/nlohmann/json/discussions/4630 On that release there is a fix for CMake 4 to be able to remove `-DCMAKE_POLICY_VERSION_MINIMUM=3.5` - https://github.com/nlohmann/json/issues/4076 We probably want to wait until their v3.12 release is out. The following diff works if we want to update now and once 3.12 is out: ```diff diff --git a/cpp/thirdparty/versions.txt b/cpp/thirdparty/versions.txt index 7b5b87bb51..5d0010010e 100644 --- a/cpp/thirdparty/versions.txt +++ b/cpp/thirdparty/versions.txt @@ -84,8 +84,8 @@ ARROW_LZ4_BUILD_VERSION=v1.10.0 ARROW_LZ4_BUILD_SHA256_CHECKSUM=537512904744b35e232912055ccf8ec66d768639ff3abe5788d90d792ec5f48b ARROW_MIMALLOC_BUILD_VERSION=v2.0.6 ARROW_MIMALLOC_BUILD_SHA256_CHECKSUM=9f05c94cc2b017ed13698834ac2a3567b6339a8bde27640df5a1581d49d05ce5 -ARROW_NLOHMANN_JSON_BUILD_VERSION=v3.10.5 -ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM=5daca6ca216495edf89d167f808d1d03c4a4d929cef7da5e10f135ae1540c7e4 +ARROW_NLOHMANN_JSON_BUILD_VERSION=v3.11.3 +ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM=0d8ef5af7f9794e3263480193c491549b2ba6cc74bb018906202ada498a79406 ARROW_OPENTELEMETRY_BUILD_VERSION=v1.13.0 ARROW_OPENTELEMETRY_BUILD_SHA256_CHECKSUM=7735cc56507149686e6019e06f588317099d4522480be5f38a2a09ec69af1706 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
