raulcd commented on code in PR #46057:
URL: https://github.com/apache/arrow/pull/46057#discussion_r2034824481
##########
python/pyarrow/acero.py:
##########
@@ -374,7 +374,7 @@ def _filter_table(table, expression):
Declaration("filter", options=FilterNodeOptions(expression))
])
result = decl.to_table(use_threads=True)
- if is_batch:
+ if is_batch and result.num_rows > 0:
Review Comment:
@AlenkaF I might have miss-understood here but shouldn't this return a Table
on that case (as per docstring?). Otherwise we should update the docstring to
specify that we can return a RecordBatch.
The initial commit returned a RecordBatch on that case, see:
https://github.com/apache/arrow/pull/46057/commits/4472ac84067e9fd33061bca2ea7cb143afdf86d4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
