raulcd commented on code in PR #46113: URL: https://github.com/apache/arrow/pull/46113#discussion_r2039583389
########## cpp/src/arrow/testing/process.cc: ########## @@ -55,11 +55,34 @@ // https://github.com/boostorg/process/blob/develop/include/boost/process/detail/windows/handle_workaround.hpp # ifdef __MINGW32__ # define BOOST_USE_WINDOWS_H = 1 -# endif -# ifdef BOOST_PROCESS_HAVE_V1 -# include <boost/process/v1.hpp> +# ifdef BOOST_PROCESS_HAVE_V2 Review Comment: we force V1 on Windows even if `BOOST_PROCESS_HAVE_V2` as per: ``` if(BOOST_PROCESS_HAVE_V2 AND # We can't use v2 API on Windows because v2 API doesn't support # process group[1] and GCS testbench uses multiple processes[2]. # # [1] https://github.com/boostorg/process/issues/259 # [2] https://github.com/googleapis/storage-testbench/issues/669 (NOT WIN32) AND # We can't use v2 API with musl libc with Boost Process < 1.86 # because Boost Process < 1.86 doesn't support musl libc[3]. # # [3] https://github.com/boostorg/process/commit/aea22dbf6be1695ceb42367590b6ca34d9433500 (NOT (ARROW_WITH_MUSL AND (Boost_VERSION VERSION_LESS 1.86)))) target_compile_definitions(Boost::process INTERFACE "BOOST_PROCESS_USE_V2") endif() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
