alamb commented on PR #7401: URL: https://github.com/apache/arrow-rs/pull/7401#issuecomment-2797052875
@zhuqi-lucas here is a proposed addition to this PR to improve the comments: - https://github.com/zhuqi-lucas/arrow-rs/pull/1 Also after thinking about this more today, I think we should have 6 predicates that generate filters in particular patterns, as described here: https://github.com/apache/arrow-rs/issues/7363#issuecomment-2797040089 I also have some smaller code suggestions I will leave inline Again, thank you for your work on this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
