alamb commented on code in PR #7405:
URL: https://github.com/apache/arrow-rs/pull/7405#discussion_r2039671415
##########
arrow-array/src/record_batch.rs:
##########
@@ -359,11 +359,12 @@ impl RecordBatch {
})
}
- /// Overrides the schema of this [`RecordBatch`]
- /// without additional schema checks. Note, however, that this pushes all
the schema compatibility responsibilities
- /// to the caller site. In particular, the caller guarantees that `schema`
is a superset
- /// of the current schema as determined by [`Schema::contains`].
- pub fn with_schema_unchecked(self, schema: SchemaRef) -> Result<Self,
ArrowError> {
+ /// Overrides the schema of this [`RecordBatch`] without additional schema
checks.
+ ///
+ /// # Safety
+ ///
+ /// `schema` must be a superset of the current schema as determined by
[`Schema::contains`]
+ pub unsafe fn with_schema_unchecked(self, schema: SchemaRef) ->
Result<Self, ArrowError> {
Review Comment:
In my opinion, if arrow users want to make RecordBatches and think they know
when they can avoid the existing checks, offering an `unsafe` API to do it is
the right thing to do. We should caveat it, etc, but at the end of the day I
don't think we should be standing in the way of allowing people to make
RecordBatches as they see fit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
