adamreeve commented on code in PR #7387:
URL: https://github.com/apache/arrow-rs/pull/7387#discussion_r2039773350


##########
parquet/src/encryption/key_management/crypto_factory.rs:
##########
@@ -0,0 +1,833 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! The key-management tools API for building file encryption and decryption 
properties
+//! that work with a Key Management Server.
+
+use crate::encryption::decrypt::FileDecryptionProperties;
+use crate::encryption::encrypt::FileEncryptionProperties;
+use crate::encryption::key_management::key_unwrapper::KeyUnwrapper;
+use crate::encryption::key_management::key_wrapper::KeyWrapper;
+use crate::encryption::key_management::kms::{KmsClientFactory, 
KmsConnectionConfig};
+use crate::encryption::key_management::kms_manager::KmsManager;
+use crate::errors::{ParquetError, Result};
+use ring::rand::{SecureRandom, SystemRandom};
+use std::collections::HashMap;
+use std::sync::Arc;
+use std::time::Duration;
+
+/// Configuration for encrypting a Parquet file using a KMS
+#[derive(Debug)]
+pub struct EncryptionConfiguration {
+    footer_key: String,
+    column_keys: HashMap<String, Vec<String>>,

Review Comment:
   :+1: good point, I've renamed these to `footer_key_id` and `column_key_ids` 
and similarly renamed other variables and methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to