kou commented on code in PR #711:
URL: https://github.com/apache/arrow-java/pull/711#discussion_r2041538929


##########
.github/workflows/rc.yml:
##########
@@ -281,6 +276,7 @@ jobs:
           set -e
           # make brew Java available to CMake
           export JAVA_HOME=$(brew --prefix 
openjdk@11)/libexec/openjdk.jdk/Contents/Home
+          export ARROW_BUILD_TESTS=OFF

Review Comment:
   How about disabling tests by default?
   
   ```diff
   diff --git a/ci/scripts/jni_macos_build.sh b/ci/scripts/jni_macos_build.sh
   index 65b255e2..f7543b6f 100755
   --- a/ci/scripts/jni_macos_build.sh
   +++ b/ci/scripts/jni_macos_build.sh
   @@ -61,7 +61,7 @@ github_actions_group_begin "Building Arrow C++ libraries"
    install_dir="${build_dir}/cpp-install"
    : "${ARROW_ACERO:=ON}"
    export ARROW_ACERO
   -: "${ARROW_BUILD_TESTS:=ON}"
   +: "${ARROW_BUILD_TESTS:=OFF}"
    export ARROW_BUILD_TESTS
    : "${ARROW_DATASET:=ON}"
    export ARROW_DATASET
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to