cultcargo commented on code in PR #2651:
URL: https://github.com/apache/arrow-adbc/pull/2651#discussion_r2042075046
##########
docs/source/driver/flight_sql.rst:
##########
@@ -246,10 +252,67 @@ to :c:struct:`AdbcDatabase`, :c:struct:`AdbcConnection`,
and
Add the header ``<HEADER NAME>`` to outgoing requests with the given
value.
- Python:
:attr:`adbc_driver_flightsql.ConnectionOptions.RPC_CALL_HEADER_PREFIX`
+ Python:
:attr:`adbc_driver_flightsql.ConnectionOptions.RPC_CALL_HEADER_PREFIX`
.. warning:: Header names must be in all lowercase.
+
+OAuth 2.0 Options
+-----------------------
+.. _oauth-configurations:
+
+Supported configurations to obtainstokens using OAuth 2.0 authentication flows.
Review Comment:
obtainstokens typo?
##########
go/adbc/driver/flightsql/flightsql_database.go:
##########
@@ -384,24 +418,30 @@ func getFlightClient(ctx context.Context, loc string, d
*databaseImpl, authMiddl
}
cl.Alloc = d.Alloc
+ // Authorization header is already set, continue
if len(authMiddle.hdrs.Get("authorization")) > 0 {
Review Comment:
should we also read under the lock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
