etseidl commented on code in PR #7307:
URL: https://github.com/apache/arrow-rs/pull/7307#discussion_r2043160346
##########
parquet/src/file/metadata/reader.rs:
##########
@@ -767,13 +767,17 @@ impl ParquetMetaDataReader {
file_decryptor = Some(get_file_decryptor(algo,
file_decryption_properties)?);
}
+ let mut first_row_number = 0;
let mut row_groups = Vec::new();
+ t_file_metadata.row_groups.sort_by_key(|rg| rg.ordinal);
Review Comment:
Are these sorts necessary? Would the ordinal ever be out of order? They
shouldn't be if I understand the [encryption
spec](https://github.com/apache/parquet-format/blob/master/Encryption.md#52-crypto-structures)
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
