AlenkaF commented on code in PR #45818: URL: https://github.com/apache/arrow/pull/45818#discussion_r2044547631
########## python/pyarrow/tests/test_scalars.py: ########## @@ -555,17 +560,23 @@ def test_binary(value, ty, scalar_typ): assert str(s) == str(value) assert repr(value) in repr(s) assert s.as_py() == value + assert bytes(s) == value assert s != b'xxxxx' buf = s.as_buffer() assert isinstance(buf, pa.Buffer) assert buf.to_pybytes() == value + memview = memoryview(s) + assert isinstance(memview, memoryview) Review Comment: ```suggestion ``` This line can be removed and some additional assertions can be added, like here: https://github.com/apache/arrow/blob/60b5ab9ee0bf070f03cf5c92fe0add0257543dfd/python/pyarrow/tests/test_tensor.py#L217-L226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org