lidavidm commented on a change in pull request #9656:
URL: https://github.com/apache/arrow/pull/9656#discussion_r606279919
##########
File path: cpp/src/arrow/ipc/reader.cc
##########
@@ -1022,7 +1111,24 @@ class RecordBatchFileReaderImpl : public
RecordBatchFileReader {
ReadStats stats() const override { return stats_; }
+ Result<AsyncGenerator<std::shared_ptr<RecordBatch>>> GetRecordBatchGenerator(
+ int readahead_messages, const io::IOContext& io_context,
+ arrow::internal::Executor* executor) override {
+ auto state =
std::dynamic_pointer_cast<RecordBatchFileReaderImpl>(shared_from_this());
+ auto message_generator = MakeMessageGenerator(state, io_context);
+ if (readahead_messages > 0) {
+ message_generator = MakeReadaheadGenerator(message_generator,
readahead_messages);
+ }
+ return IpcFileRecordBatchGenerator(
+ std::move(state), std::move(message_generator),
+ executor ? executor : arrow::internal::GetCpuThreadPool());
Review comment:
Well, scratch that - I messed up my Git commands and so the above graphs
only benchmarks the effect of fewer I/O operations. I'll also test not
transferring…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
