AdamGS opened a new pull request, #334: URL: https://github.com/apache/arrow-rs-object-store/pull/334
# Which issue does this PR close? Closes #320 <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #. # Rationale for this change https://github.com/apache/arrow-rs/pull/7183 Changed the way URLs are built from: ``` azurebase.com/path?comp=list&restype:container ``` to: ``` azurebase.com/path?&comp=list&restype:container ``` That data is encoded into `application/x-www-form-urlencoded` form, which is then parsed by Azure into three pairs, with one of them being empty. The `Url` crate seems to ignore these when parsing the underlying string in `Url::query_pairs`, so we create a different canonicalized resource and sign a different string than the one Azure expects. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? 1. Fixes a bug in the request builder when adding query params to a request that already has a path component. 2. Some minor touchups to the `CONTRIBUTING.md` which seemed to reference some env variables that are no longer in use. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are there any user-facing changes? No changes to public APIs, but if a user relayed on this pretty obscure behavior, their code will break. Its important to note that this change brings the crate back to the same behavior it had in `0.11.2`. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please call them out. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
