WillAyd commented on code in PR #46162:
URL: https://github.com/apache/arrow/pull/46162#discussion_r2046983251
##########
cpp/src/arrow/testing/gtest_util_test.cc:
##########
@@ -292,6 +292,7 @@ TEST(AssertTestWithinUlp, Basics) {
EXPECT_FATAL_FAILURE(AssertWithinUlp(123.456f, 123.456085f, 10), "not within
10 ulps");
}
+#ifdef ARROW_COMPUTE
Review Comment:
Ah that's great - thanks for taking a look! I agree your solution is more
robust - let's roll with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
