nealrichardson commented on a change in pull request #9875:
URL: https://github.com/apache/arrow/pull/9875#discussion_r606379630
##########
File path: r/R/compute.R
##########
@@ -80,6 +80,36 @@ collect_arrays_from_dots <- function(dots) {
ChunkedArray$create(!!!arrays)
}
+#' @export
+quantile.ArrowDatum <- function(x,
+ probs = seq(0, 1, 0.25),
+ na.rm = FALSE,
+ interpolation = c("linear", "lower", "higher",
"nearest", "midpoint"),
+ ...) {
Review comment:
can/should you accept the `type` parameter that `quantile` takes and map
to the interpolation methods where appropriate?
We don't have docs for the other compute function methods, but they also
don't take additional Arrow arguments IIRC. I don't think docs would help here
(if you type `?quantile` you'd have to choose which help page to load, which
usually is confusing IME), I'd just make sure that we link to the appropriate
C++ docs somewhere (do we need another compute-specific vignette, or save this
for when dplyr supports aggregation?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
