alamb commented on code in PR #329:
URL:
https://github.com/apache/arrow-rs-object-store/pull/329#discussion_r2048922084
##########
tests/http.rs:
##########
@@ -41,3 +44,23 @@ async fn test_http_store_gzip() {
.await
.unwrap();
}
+
+#[cfg(all(feature = "http", target_arch = "wasm32", target_os = "unknown"))]
+#[wasm_bindgen_test]
+async fn basic_wasm_get() {
Review Comment:
I verified this runs in CI:
https://github.com/apache/arrow-rs-object-store/actions/runs/14505171194/job/40723998384?pr=329#step:11:138
```
warning: `object_store` (lib) generated 1 warning
warning: `object_store` (lib test) generated 4 warnings (run `cargo fix
--lib -p object_store --tests` to apply 3 suggestions)
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.11s
Running unittests src/lib.rs
(target/wasm32-unknown-unknown/debug/deps/object_store-4bf7d6aa80f96256.wasm)
no tests to run!
Running tests/http.rs
(target/wasm32-unknown-unknown/debug/deps/http-0715721c2cebdfb7.wasm)
Executing bindgen...
running 1 test
test basic_wasm_get ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 filtered out; finished in
0.36s
```
So looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
