paleolimbot commented on PR #2713: URL: https://github.com/apache/arrow-adbc/pull/2713#issuecomment-2813193986
This definitely seems correct in the sense that it is statically communicating the constraints of the ADBC object lifetimes as written in the spec correctly. It is also true that static lifetime annotations make writing wrappers (like the one Felipe demoed) highly unenjoyable and/or impossible to combine with calls to another library that is highly enthusiastic about lifetime annotations. I would definitely prefer to return `Box<dyn RecordBatchReader>`...as Felipe pointed out, this type of annotation can always be added at a higher level of abstraction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
