yyossy5 commented on code in PR #46170:
URL: https://github.com/apache/arrow/pull/46170#discussion_r2049144944


##########
python/pyarrow/array.pxi:
##########
@@ -4655,6 +4657,17 @@ cdef class FixedShapeTensorArray(ExtensionArray):
                 "Cannot convert 1D array or scalar to fixed shape tensor 
array")
         if np.prod(obj.shape) == 0:
             raise ValueError("Expected a non-empty ndarray")
+        if dim_names is not None:
+            if not hasattr(dim_names, '__iter__'):

Review Comment:
   Thank you @raulcd !
   Fixed it in 
https://github.com/apache/arrow/pull/46170/commits/38ae0a4534d5bab2352f7a0d1bb89ea7b379e139
 and added a test case for generator input in 
https://github.com/apache/arrow/pull/46170/commits/ff2ff30f79abce1a7eef32c3f1945805ae6d6687
 .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to