kapoisu opened a new pull request, #46202: URL: https://github.com/apache/arrow/pull/46202
### Rationale for this change ### What changes are included in this PR? * Pass std::string by value to constructors and Make(). * Pass std::shared_ptr<::arrow::fs::FileSystem> by value to constructors and Make(). * Use emplace() instead of insert() in AddKeyMaterial() because the parameters can be moved. ### Are these changes tested? This is the first time I contribute to this project; thus, I'm not sure if the section I've modified is covered by "make unittest". I'd be happy to learn that which build targets are necessary and what test processes I have to run through for such changes. ### Are there any user-facing changes? No. **This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.) The interface of parquet::encryption::FileSystemKeyMaterialStore has been changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
