raulcd commented on code in PR #46161: URL: https://github.com/apache/arrow/pull/46161#discussion_r2055835333
########## cpp/src/arrow/compute/kernels/test_util.h: ########## @@ -0,0 +1,30 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: It seems this is the case for all the different `test_util_internal.cc`. I think we can keep `RunEndEncodeTableColumns` at `acero/test_util_internal.cc` as is on the last commit. The function is used on a single test on acero (nowhere else). Doesn't require to be exported as it does not go into a DLL. We can discuss if we want to refactor how we export the different internal APIs for `test_util_internal` and whether we should have a public utilities testing DLL on a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
