hachikuji commented on code in PR #319:
URL:
https://github.com/apache/arrow-rs-object-store/pull/319#discussion_r2056498053
##########
src/client/connection.rs:
##########
@@ -108,12 +108,15 @@ impl HttpError {
} else if e.is_timeout() {
kind = HttpErrorKind::Timeout;
}
- break;
Review Comment:
I think the problematic part is that we break regardless of whether any of
the conditions (`is_closed`, `is_timeout`...) are true. It would probably be
fine to only break if one of them is satisfied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
