amoeba commented on PR #46180:
URL: https://github.com/apache/arrow/pull/46180#issuecomment-2825902742
I'm not sure the benefit of putting these helpers in the public API
outweighs the downsides of renaming `arrow/json` for users and the work
required for us. @pitrou's point about avoiding confusion is important though.
I also don't think `arrow/jsonl` is really more correct than `arrow/json` since
JSONL (the format) falls under the umbrella of JSON (the
concept/standard/grammar).
I should also point out that there are other `*FromJSON` helpers we should
consider moving into the public API in future PRs (notably
`RecordBatchFromJSON`/`TableFromJSON` but probably others) and what we do here
may interact with that work. The ones I'm thinking of currently span
`arrow/util`, `arrow/compute`, `arrow/dataset`, and could even include
`arrow/engine/substrait`. I was thinking we'd have a few `from_json.{h,cc}`
files in various sub-trees of the repo but maybe this is even more confusing.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
